Fixes type hint non using direct import from 'multiprocessing' #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorborgest
added
bug
Contributor
|
@phakiller awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #151
Description of changes:
In python 3.7 or above people get the error:
AttributeError: module 'multiprocessing' has no attribute 'connection'To fix this, instead of using
mp.connection.Connectionto make the Type Hints now we importConnectionfrommultiprocessing.connection:And to be more meaningful
Connectionwas aliased asMultiprocessingConnection.In some circumstances a get the same error using Python 3.6.9 on Manjaro, but using the same Python version on Ubuntu works and these changes fix for these cases as well.
Closes #151
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.